Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Fix for 1 vulnerable dependencies #297

Closed
wants to merge 1 commit into from
Closed

Conversation

snyk-bot
Copy link
Contributor

@snyk-bot snyk-bot commented May 5, 2019

Description

This PR fixes one or more vulnerable packages in the npm dependencies of this project.
See the Snyk test report for more details.

Snyk Project: pact-foundation/pact-js:examples/typescript/package.json

Snyk Organization: mboudreau

Changes included in this PR

Vulnerabilities that will be fixed

With a Snyk patch:

You can read more about Snyk's upgrade and patch logic in Snyk's documentation.

Check the changes in this PR to ensure they won't cause issues with your project.

Stay secure,
The Snyk team

Note: You are seeing this because you or someone else with access to this repository has authorised Snyk to open Fix PRs. To review the settings for this Snyk project please go to the project settings page.

…reduce vulnerabilities

The following vulnerabilities are fixed with a Snyk patch:
- https://snyk.io/vuln/SNYK-JS-AXIOS-174505
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.041% when pulling a7b95b5 on snyk-fix-iglts2 into f6e2da4 on master.

@TimothyJones
Copy link
Contributor

I don't think we need this. This is a synk patch, which means it configures synk to replace vulnerable code after an npm install (synk do this when the upstream is unpatchable/not patched for some reason).

However, it's only in the example, and I think adding extra build steps to the example is probably just going to overcomplicate things. Thoughts, @mefellows ?

@mefellows
Copy link
Member

I agree, reject.

@mefellows mefellows closed this May 29, 2019
@mefellows mefellows deleted the snyk-fix-iglts2 branch May 29, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants