Eliminate memory leak in logger for jest #399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ertrzyiks
force-pushed
the
eliminate-memory-leak-from-logger-for-jest
branch
3 times, most recently
from
e4a2682
to
a904dcb
Compare
`.pipe()` call attaches events listeners to the writeable stream which in case of stdout and sequential jest tests causes memory leak as those listeners are added for every test file. Since stdout stream is special, for example it never ends while the process is runing, we can use simplified piping by listening to the `data` event of the readable stream and redirect data to stdout. This way no listeners are leaking.
ertrzyiks
force-pushed
the
eliminate-memory-leak-from-logger-for-jest
branch
from
a904dcb
to
8489bb0
Compare
1 similar comment
|
Thanks @ertrzyiks, this looks good. When I get a moment I'll have a closer look and bring it in if no issues. Much appreciated. |
|
Looks good to me! Thanks very much! |
|
Ah, I tried this out using |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Closing until somebody can pick it back up again. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #397
.pipe()call attaches events listeners to the writeable streamwhich in case of stdout and sequential jest tests causes memory
leak as those listeners are added for every test file.
Since stdout stream is special, for example it never ends while
the process is runing, we can use simplified piping by
listening to the
dataevent of the readable stream andredirect data to stdout. This way no listeners are leaking.