Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't JSON.stringify body if its already a string #578

Merged
merged 2 commits into from Jan 20, 2021
Merged

fix: don't JSON.stringify body if its already a string #578

merged 2 commits into from Jan 20, 2021

Conversation

individual-it
Copy link
Contributor

if the body is already a string don't try to stringify it

fixes #577

alternatively we could get rid of JSON.stringify all together, the limited e2e tests also pass then

@individual-it
Copy link
Contributor Author

I don't see why CI would fail, but it must be because of the change #579 passes
digging into it

@individual-it
Copy link
Contributor Author

or it is a timeout issue, here is passed in around 8sec
image

so 10 sec timeout might be just to little

@mefellows
Copy link
Member

Thanks, this looks ok to my eyes.

The failure with the Windows build is a know one (there is an issue with message pact on Windows due to argument spawning).

I'll look at bringing it in tomorrow.

Copy link
Contributor

@TimothyJones TimothyJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this! One small comment about side effects, other than that this is good to go.

src/v3/pact.ts Outdated Show resolved Hide resolved
@TimothyJones TimothyJones merged commit fe0cb4b into pact-foundation:feat/v3.0.0 Jan 20, 2021
@TimothyJones
Copy link
Contributor

Merged! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants