Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README installation instructions #865

Merged
merged 3 commits into from May 11, 2022

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented May 10, 2022

  • npm run dist works locally (this will run tests, lint and build)
  • Commit messages are ready to go in the changelog (see below for details)
  • PR template filled in (see below for details)

PR Template

From slack discussion

https://pact-foundation.slack.com/archives/C9VBGLUM9/p1652174044653219

installation instructions should advise to install in devDeps

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@mefellows mefellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should just be -D

Co-authored-by: Matt Fellows <matt.fellows@onegeek.com.au>
@YOU54F
Copy link
Member Author

YOU54F commented May 10, 2022

I think it should just be -D

Doh!

I actually wanted to be verbose, as in the other commands, with --save-dev and suggest -D as short-hand as not every user, especially newbies understand. I didn't when I started in the ecosystem

@YOU54F
Copy link
Member Author

YOU54F commented May 10, 2022

Hmm. The build is failing on one of the examples

https://github.com/pact-foundation/pact-js/runs/6370766697?check_suite_focus=true#step:4:1214

Disconnected reconnect failed before timeout of 2000ms (transport close)

This is an awfully short timeout

10 05 2022 13:30:58.776:INFO [karma-pact]: Pact Mock Server running on port: 1234
10 05 2022 13:30:58.818:INFO [karma-server]: Karma v6.3.16 server started at http://localhost:9876/
10 05 2022 13:30:58.819:INFO [launcher]: Launching browsers Chrome_without_security with concurrency unlimited
10 05 2022 13:30:58.824:INFO [launcher]: Starting browser ChromeHeadless
10 05 2022 13:31:00.561:INFO [Chrome Headless 78.0.3882.0 (Linux x86_64)]: Connected on socket 6_VkRWeufE5oqchsAAAB with id 5119395
Chrome Headless 78.0.3882.0 (Linux x86_64): Executed 0 of 4 SUCCESS (0 secs / 0 secs)
INFO: 'Setting up Pact using mock service on port: "1234"'
Chrome Headless 78.0.3882.0 (Linux x86_64): Executed 0 of 4 SUCCESS (0 secs / 0 secs)
10 05 2022 13:31:04.041:WARN [Chrome Headless 78.0.3882.0 (Linux x86_64)]: Disconnected (0 times) reconnect failed before timeout of 2000ms (transport close)
Chrome Headless 78.0.3882.0 (Linux x86_64) ERROR
  Disconnected reconnect failed before timeout of 2000ms (transport close)
Chrome Headless 78.0.3882.0 (Linux x86_64): Executed 0 of 4 DISCONNECTED (3.282 secs / 0 secs)
Chrome Headless 78.0.3882.0 (Linux x86_64): Executed 0 of 4 DISCONNECTED (3.282 secs / 0 secs)
[2022-05-10 13:31:04.070 +0000] INFO (2979 on fv-az451-700): pact-node@10.17.2: Removing all Pact servers.
[2022-05-10 13:31:04.071 +0000] INFO (2979 on fv-az451-700): pact-node@10.17.2: Removing Pact process with PID: 2986
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! pact-js-karma@1.0.0 test:mocha: `karma start ./mocha/karma.conf.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the pact-js-karma@1.0.0 test:mocha script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

@mefellows
Copy link
Member

Let's merge this in and fix the timeout issue separately.

@mefellows mefellows merged commit 21a458e into master May 11, 2022
@mefellows mefellows deleted the update-readme-installation branch May 11, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants