Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(migration): Correct migration guide #916

Merged
merged 1 commit into from Aug 11, 2022

Conversation

TimothyJones
Copy link
Contributor

  • npm run dist works locally (this will run tests, lint and build)
  • Commit messages are ready to go in the changelog (see below for details)
  • PR template filled in (see below for details)

This PR corrects the migration guide with some information about changes to the provider verifier, following feedback from Adam Witko on slack: https://pact-foundation.slack.com/archives/C9VBGLUM9/p1660227998292199

Following feedback from Adam Witko on slack: providerVersionBranch
Copy link
Member

@mefellows mefellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim.

@mefellows
Copy link
Member

Going to also consider if we can make these backwards compatible, but for now it's good for this to be clear - thanks!

@mefellows mefellows merged commit 02885f8 into pact-foundation:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants