Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(compatibility-suite): Implement V3 scenarios #431

Merged
merged 2 commits into from
Dec 24, 2023

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Dec 23, 2023

@Lewiscowles1986
Copy link
Collaborator

Lewiscowles1986 commented Dec 23, 2023

Can you force the failing cases to skip or xfail for now?
Even filtering out by tag would help https://docs.behat.org/en/v2.5/guides/6.cli.html#gherkin-filters

@tienvx
Copy link
Contributor Author

tienvx commented Dec 23, 2023

Updated using tag filtering

@tienvx
Copy link
Contributor Author

tienvx commented Dec 23, 2023

Updated using tag filtering

nevermind, it doesn't work as expected, close for now while waiting for the solution

@tienvx tienvx closed this Dec 23, 2023
@tienvx
Copy link
Contributor Author

tienvx commented Dec 23, 2023

Fixed. It's a bit complicated than I thought.

There is no way I can set this filter to v3_message_provider suite's config:

            filters:
                name: '/^((?!Kafka|binary body \(negative).)*$/'

The filters array is flipped, probably because of this code https://github.com/Behat/Behat/blob/master/src/Behat/Behat/Gherkin/ServiceContainer/GherkinExtension.php#L97.

There is another option is to use --name flag. But because of the way it work (scenarios are not filtered if feature is matched), I have to filter out the feature as well.

 --name '/^((?!Kafka|binary body \(negative|Message provider).)*$/'

Copy link
Collaborator

@Lewiscowles1986 Lewiscowles1986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to argue with well-documented, working code. Hope the other PR's land safely

@tienvx tienvx merged commit 7a9824e into pact-foundation:ffi Dec 24, 2023
23 of 29 checks passed
@tienvx tienvx deleted the v3-scenarios branch December 24, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants