New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff Pattern Matching #458

Open

4 of 5 tasks

JP-Ellis opened this issue Nov 6, 2023 · 1 comment · Fixed by #459

Assignees

Labels

area:ci area:v3 difficulty:easy smartbear-supported type:bug

Contributor

JP-Ellis commented Nov 6, 2023

Have you read the Contributing Guidelines on issues?

I have read the Contributing Guidelines on issues.

Prerequisites

I'm using the latest version of pact-python.
I have read the console error message carefully (if applicable).

Description

Ruff's exclude pattern matching is over-zealous, and patterns which should match files within a directory are instead recursive.

This is an upstream issue:

exclude pattern with * in file name incorrectly matches entire file path astral-sh/ruff#6262

Reproducible demo

No response

Steps to reproduce

Checkout master
Run ruff and note that nothing is fixed/raised

Expected behavior

Ruff should correctly lint files in v3 (both within Pact and tests)

Actual behavior

Ruff's ignore is overly eager.

Your environment

No response

Self-service

I'd be willing to fix this bug myself.

The text was updated successfully, but these errors were encountered:

JP-Ellis self-assigned this

JP-Ellis added type:bug smartbear-supported difficulty:easy area:ci area:v3 and removed smartbear-supported labels

JP-Ellis mentioned this issue

Fix/ruff linting #459

Merged

JP-Ellis closed this as completed in #459

Contributor Author

JP-Ellis commented Nov 6, 2023

Re-opening as #459 is only a temporary workaround.

JP-Ellis reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment