Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ruff linting #459

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Fix/ruff linting #459

merged 2 commits into from
Nov 6, 2023

Conversation

JP-Ellis
Copy link
Contributor

@JP-Ellis JP-Ellis commented Nov 6, 2023

📝 Summary

🚨 Breaking Changes

🔥 Motivation

Fixes a bug

🔨 Test Plan

Covered by CI

🔗 Related issues/PRs

As above

Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis JP-Ellis added type:fix Fix to an issue area:ci Relating to the CI/CD workflow labels Nov 6, 2023
@JP-Ellis JP-Ellis self-assigned this Nov 6, 2023
@JP-Ellis JP-Ellis added difficulty:easy A simple task appropriate for newcomers to the codebase area:v3 Relating to the pact.v3 module labels Nov 6, 2023
Due to an upstream bug in `ruff`, all Python files were inadvertently
ignored instead of just the `v2` code. As a result, lint errors have
been accummulating.

Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis JP-Ellis enabled auto-merge (rebase) November 6, 2023 04:36
@JP-Ellis JP-Ellis merged commit d1724bf into master Nov 6, 2023
24 of 30 checks passed
@JP-Ellis JP-Ellis deleted the fix/ruff-linting branch November 6, 2023 04:39
@JP-Ellis JP-Ellis mentioned this pull request Nov 6, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Relating to the CI/CD workflow area:v3 Relating to the pact.v3 module difficulty:easy A simple task appropriate for newcomers to the codebase type:fix Fix to an issue
Projects
Status: ✅ Completed
Development

Successfully merging this pull request may close these issues.

Ruff Pattern Matching
1 participant