feat: added support for message provider using pact broker #257
Conversation
|
This is looking great again! Just one question around the examples tests. I'll need to hook these into CI I think as well. I think I have an example that uses test containers you might want to consider btw. |
fix: updated message_pact to wait writing contract process to finish
I did change the examples for messages to use a broker docker instance. |
| }, | ||
| provider='ContentProvider', | ||
| consumer='DetectContentLambda', | ||
| pact_dir='pacts' |
There was a problem hiding this comment.
the pact_dir should not be here anymore and works just fine if you remove it.
| 'A document created successfully': document_created_handler, | ||
| }, | ||
| provider='ContentProvider', | ||
| consumer='DetectContentLambda', |
There was a problem hiding this comment.
I believe the consumer should no longer be mandatory because does not make sense since you fetch the data from the pact broker
|
Sorry - I've been busy and then sick this week. I'll hopefully get to it this weekend. |
| @@ -115,6 +115,25 @@ def verify(self): | |||
| return_code, _ = verifier.verify_pacts(pact_files, verbose=False) | |||
| assert (return_code == 0), f'Expected returned_code = 0, actual = {return_code}' | |||
|
|
|||
| def verify_with_broker(self, enable_pending=False, include_wip_pacts_since=None, **kwargs): | |||
There was a problem hiding this comment.
Is this user facing code? It's missing the consumer version selectors. How can we get those supported?
There was a problem hiding this comment.
The API docs for fetching the pacts for verification are here: https://github.com/pact-foundation/pact_broker/blob/master/lib/pact_broker/doc/views/provider-pacts-for-verification.markdown
Added Pact Broker Support for Message Provider Issue #253