Remove support for x86 linux #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mefellows
changed the title
|
No longer needed with #342 as this restores x86 packages in travelling ruby. I am not sure how many users we having using 32 bit, and whether it would be supporting in the Pact FFI officially (I have some unofficial builds cooked up) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing build here: #319
See pact-foundation/pact-ruby-standalone#75
Travelling ruby has deprecated support for linux-x86 (x86_64 is still supported), so that's been removed from the created packages.
This PR essentially drops support for linux x86.
This probably ought to be a major version bump, but I'll leave that to the maintainer to decide. I suspect not many people use this architecture.