Feat: ARM64 Support for OSX / Linux + Windows 32 bit support #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YOU54F
commented
Apr 21, 2023
| linux_arm64_task: | ||
| env: | ||
| matrix: | ||
| # - IMAGE: python:3.6-slim # This works locally, with cirrus run, but fails in CI |
There was a problem hiding this comment.
YOU54F
commented
Apr 21, 2023
| # https://github.com/pyenv/pyenv/wiki#suggested-build-environment | ||
| # - xcode-select --install # Unnecessary on Cirrus | ||
| - brew update | ||
| # - brew install openssl readline sqlite3 xz zlib |
There was a problem hiding this comment.
preinstalled in cirrus's base image
YOU54F
commented
Apr 21, 2023
| - pyenv global ${PYTHON} | ||
| - pyenv rehash | ||
| ## To install rosetta | ||
| # - softwareupdate --install-rosetta --agree-to-license |
There was a problem hiding this comment.
rosetta isn't installed by default, so this is using arm64 binaries, and would fail if using x86_64 binaries without rosetta
YOU54F
commented
Apr 21, 2023
| @@ -19,7 +19,7 @@ jobs: | |||
| - '3.9' | |||
| - '3.10' | |||
| - '3.11' | |||
| os: [ ubuntu-latest ] | |||
| os: [ ubuntu-latest, windows-latest, macos-latest ] | |||
There was a problem hiding this comment.
adds additional os's but skips the examples steps, as they require a broker and spin one up with docker-compose.
docker isn't available in GH runners for macOS or Windows, hence skipped on line 53 unless Linux
YOU54F
commented
Apr 21, 2023
| - name: Set up Python | ||
| uses: actions/setup-python@v2 | ||
| uses: actions/setup-python@v4 |
There was a problem hiding this comment.
matches .github/workflows/build_and_test.yml
YOU54F
commented
Apr 21, 2023
| @@ -29,7 +29,7 @@ jobs: | |||
|
|
|||
| steps: | |||
| - name: Check out code | |||
| uses: actions/checkout@v2 | |||
| uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
fix deprecation warnings in build
|
Thank you for the patch, and for helping make pact-python better! |
This was referenced May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to traveling ruby to support additional platforms
Details of changes made to travelling ruby
PR's to Travelling ruby to update the supported archs
Which means we can now support
Details of changes made to pact-ruby-standalone
Details of changes made to pact-python
These have been consumed in the pact-python project, and tested cross platform
In order to test ARM64 on MacOS, and Linux, I have utilised cirrus-ci, which is free for open-source usage (within reasonable limits)