Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrieving public key from wallet for bond transactions #485

Merged
merged 5 commits into from May 27, 2023

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented May 25, 2023

Description

This PR includes several changes:

  • Made the public key for the Bond transaction optional.
  • Obtained the validator's public key from the wallet.
  • Checked if the validator exists and removed the public key before signing and broadcasting the Bond transaction.
  • Added a hint string for the receiver in the Bond and Send transactions within the GUI.
  • Modify the display of amounts to show them without trailing zeros.

Overall, this PR aims to simplify the Bond transaction dialog and enhance the user experience for easily sending Bond transactions.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #485 (4a0de7e) into main (aa8b886) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 4a0de7e differs from pull request most recent head 08071dc. Consider uploading reports for the commit 08071dc to get more accurate results

@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
+ Coverage   82.44%   82.48%   +0.03%     
==========================================
  Files         150      150              
  Lines        7059     7069      +10     
==========================================
+ Hits         5820     5831      +11     
+ Misses        945      944       -1     
  Partials      294      294              

wallet/tx_builder.go Show resolved Hide resolved
wallet/wallet.go Show resolved Hide resolved
wallet/wallet_test.go Outdated Show resolved Hide resolved
wallet/wallet_test.go Outdated Show resolved Hide resolved
@themantre themantre enabled auto-merge (squash) May 27, 2023 07:12
@themantre themantre merged commit 232017f into pactus-project:main May 27, 2023
10 checks passed
@b00f b00f deleted the gui_simpler_bond branch May 27, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants