HHVM Fixes #270
Closed
HHVM Fixes #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests pass on every php version now. :P |
| @@ -21,7 +21,8 @@ | |||
| "lib-pcre": ">=7.0" | |||
| }, | |||
| "require-dev": { | |||
| "hamcrest/hamcrest-php": "~1.1", | |||
| "phpunit/phpunit": "4.0.*", | |||
| "hamcrest/hamcrest-php": "1.1.*", | |||
There was a problem hiding this comment.
Why tighten this requirement?
There was a problem hiding this comment.
To make sure there are no unexpected changes. You can always raise the version when 1.2 is release, or I can revert this change if you like?
There was a problem hiding this comment.
Because it's a dev requirement, by keeping it loose, if they do break BC, we might catch it before one of our users catches it. Also, I think I'm a maintainer on that repo, so will be whinging at people if they break BC, if I have my way we'll stick to semver from now onwards.
There was a problem hiding this comment.
Ok. Sure. Check out my take 3?
|
I'll redo this pull... |
|
See #271. |
|
See #274. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's load in phpunit 4.0. Let's make sure we only try to push to coveralls if we are not using hhvm.