Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tearDown function is protected (last one :) #322

Closed
wants to merge 1 commit into from
Closed

tearDown function is protected (last one :) #322

wants to merge 1 commit into from

Conversation

carlosbuenosvinos
Copy link

No description provided.

@aik099
Copy link

aik099 commented Apr 21, 2014

I also wondered why everybody out there (except PHPUnit own documentation: http://phpunit.de/manual/current/en/fixtures.html#fixtures.more-setup-than-teardown) is teaching that when overriding the setUp/tearDown method in test class they need to be set as public.

Thanks for the contribution. Can you please look at the setUp method (if it exists) as well?

@GrahamCampbell
Copy link
Contributor

Could all these pulls go into one commit?

@aik099
Copy link

aik099 commented Apr 21, 2014

Can you please combine the #319, #320, #321 and #322 into a single PR? I don't see much sense to have a single PR per file.

This was referenced Apr 21, 2014
Closed
Closed
@carlosbuenosvinos
Copy link
Author

I'll do it now. It was just fixing while reading.

@aik099 aik099 mentioned this pull request Apr 21, 2014
Closed
@carlosbuenosvinos
Copy link
Author

Closing this one, the final one is #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosbuenosvinos @aik099 @GrahamCampbell