Make use of doctrine/instantiator #375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
davedevelopment
force-pushed
the
instantiator
branch
from
47dfc8f
to
cf44ff1
Compare
|
Reported the clone problem over at doctrine/instantiator#7 |
|
Don't think the HHVM issue is going to get fixed any time soon. As for php 5.3, I'm considering excluding those tests that will fail. |
|
Reported another issue with instantiator, but it will probably need taking up with HHVM doctrine/instantiator#9 |
|
Closing this in favour of #403 for now, may revisit at a later date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this will make things a little easier going forward, phpunit are already using it and of course doctrine