Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a failing test for mocking an exception #456

Merged
merged 1 commit into from
Mar 13, 2015

Conversation

duncan3dc
Copy link
Contributor

This test demonstrates an issue on hhvm when mocking instances of the base Exception class. I've not been able to figure out why it fails though

BadMethodCallException: Call to a member function mockery_getName() on a non-object (NULL)

/home/craig/dev/duncan3dc/mockery/library/Mockery/Container.php:473
/home/craig/dev/duncan3dc/mockery/library/Mockery/Container.php:221
/home/craig/dev/duncan3dc/mockery/library/Mockery.php:74
/home/craig/dev/duncan3dc/mockery/tests/Mockery/MockTest.php:141

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.32% when pulling 7203064 on duncan3dc:hhvm-exception-test into 491dcbb on padraic:master.

@padraic
Copy link
Member

padraic commented Mar 13, 2015

Thanks @duncan3dc . I'll merge this and hopefully the hhvm guys will get around to looking at it.

padraic added a commit that referenced this pull request Mar 13, 2015
Create a failing test for mocking an exception
@padraic padraic merged commit 8f49adc into mockery:master Mar 13, 2015
@duncan3dc duncan3dc deleted the hhvm-exception-test branch September 9, 2015 10:19
@ldct
Copy link
Contributor

ldct commented Feb 23, 2016

Could it be related to this?

sebastianbergmann/phpunit-mock-objects#207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants