Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first expectations are less specific than last #566

Closed
wants to merge 7 commits into from

Conversation

tflori
Copy link
Contributor

@tflori tflori commented Apr 1, 2016

a simple array_reverse can fix some tests at least in my case.

but it should be testet too. say me where I should write this test and I can write a test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.841% when pulling 1800a5f on tflori:feature/firstinLastOut into 64d0c31 on padraic:master.

@tflori
Copy link
Contributor Author

tflori commented Apr 1, 2016

I already realized it breaks other things and working on it

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 74.021% when pulling d28cd76 on tflori:feature/firstinLastOut into 64d0c31 on padraic:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 74.021% when pulling c1895a7 on tflori:feature/firstinLastOut into 64d0c31 on padraic:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 76.176% when pulling 9423190 on tflori:feature/firstinLastOut into d4f0db5 on padraic:master.

@tflori
Copy link
Contributor Author

tflori commented Jan 11, 2017

why from master comes code with wrong code style? 👎

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 78.057% when pulling 12ac94a on tflori:feature/firstinLastOut into 7e9a844 on padraic:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 78.057% when pulling 12ac94a on tflori:feature/firstinLastOut into 7e9a844 on padraic:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 78.057% when pulling 12ac94a on tflori:feature/firstinLastOut into 7e9a844 on padraic:master.

@coveralls
Copy link

coveralls commented Mar 2, 2017

Coverage Status

Coverage increased (+0.1%) to 78.057% when pulling 12ac94a on tflori:feature/firstinLastOut into 7e9a844 on padraic:master.

@robertbasic
Copy link
Collaborator

Hey @tflori thanks for the PR, and I apologize that no one from the team took a look at it yet. I'm trying to fix that now.

Could you explain what's the original issue that you're trying to solve with this PR?

Thanks!

@tflori
Copy link
Contributor Author

tflori commented Feb 5, 2018

Hi, I don't remember which issue it was but at the end I solved my problems with ->byDefault().

Now that I know about by default I don't need it anymore but I still think that this order makes more sense.

@davedevelopment
Copy link
Collaborator

I think we'd need to do something more complex if we wanted this as a feature and it would need to make it's way to 2.0, so will close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants