Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't declare two classes in one file #708

Merged
merged 2 commits into from
Mar 2, 2017

Conversation

tflori
Copy link
Contributor

@tflori tflori commented Mar 2, 2017

No description provided.

@coveralls
Copy link

coveralls commented Mar 2, 2017

Coverage Status

Coverage remained the same at 77.913% when pulling 8340d61 on tflori:fix-phpunitIntegration into 7e9a844 on padraic:master.

@davedevelopment
Copy link
Collaborator

I didn't know about the class in 5.4 that you mentioned, so if we can agree to drop support for PHPUnit < 5.4, we can skip the separate class definitions.

I definitely do not want to remove the trait completely, that's a backwards step for me.

@tflori
Copy link
Contributor Author

tflori commented Mar 2, 2017

https://github.com/sebastianbergmann/phpunit/blob/5.4/src/ForwardCompatibility/TestCase.php

For me: yes but I'm not maintainer of mockery. mockery requires php >= 5.6 and in this versions you can use the still supported phpunit 5.7. I don't know a reason for using php 4.8 other than dealing with php 5.3.

btw.: phpunit stops supporting php5.6 in february

@coveralls
Copy link

coveralls commented Mar 2, 2017

Coverage Status

Coverage remained the same at 77.913% when pulling 35de8e8 on tflori:fix-phpunitIntegration into 7e9a844 on padraic:master.

@davedevelopment davedevelopment merged commit 322749d into mockery:master Mar 2, 2017
@davedevelopment
Copy link
Collaborator

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants