-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#171330968] Add a modal to handle backend systems failure #1573
[#171330968] Add a modal to handle backend systems failure #1573
Conversation
Affected stories
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1573 +/- ##
=========================================
Coverage ? 42.42%
=========================================
Files ? 325
Lines ? 9521
Branches ? 2130
=========================================
Hits ? 4039
Misses ? 5463
Partials ? 19
Continue to review full report at Codecov.
|
@Undermaken I just solved the conflicts within 5fab941. One question: I see there are 2 forked sagas on the sagas index, |
Affected stories
Generated by 🚫 dangerJS |
fix a bug on uncaught exception in loadSessionInformationSaga fix a bug on appState initial state: it was background
add tests
add logic to make multiple check when systems seem dead
@valentinacala
Furthermore they could have different endpoint
so imho they should be separated cause they have different logic. Anyway if you find other points because they should be together, we can talk about them |
limit dead counter
now backendInfo is provided by backendStatus
…l-for-current-services-status # Conflicts: # package.json # ts/RootContainer.tsx # ts/sagas/backendInfo.ts # ts/sagas/index.ts # ts/store/actions/types.ts # ts/store/reducers/backendInfo.ts # ts/store/reducers/index.ts # ts/store/reducers/types.ts
Short description:
This PR includes a mechanism to handle ko status on backend side.
If all or some systems can't provide their service a modal screen will be shown.
Based on failure severity the access to the app could be forbidden