Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#171330968] Add a modal to handle backend systems failure #1573

Merged
merged 55 commits into from
Mar 30, 2020

Conversation

Undermaken
Copy link
Contributor

Short description:
This PR includes a mechanism to handle ko status on backend side.
If all or some systems can't provide their service a modal screen will be shown.
Based on failure severity the access to the app could be forbidden

@digitalcitizenship
Copy link

digitalcitizenship commented Feb 27, 2020

Affected stories

  • 🐞 #171101699: [major] se effettuo un pagamento subito dopo averne concluso uno non riesco a procedere

Generated by 🚫 dangerJS

@Undermaken Undermaken changed the title [#171101699] Add a modal to handle backend systems failure [#171330968] Add a modal to handle backend systems failure Mar 2, 2020
@codecov-io
Copy link

codecov-io commented Mar 9, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b8991ec). Click here to learn what that means.
The diff coverage is 52.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1573   +/-   ##
=========================================
  Coverage          ?   42.42%           
=========================================
  Files             ?      325           
  Lines             ?     9521           
  Branches          ?     2130           
=========================================
  Hits              ?     4039           
  Misses            ?     5463           
  Partials          ?       19
Impacted Files Coverage Δ
...sagas/services/handleOrganizationNameUpdateSaga.ts 100% <ø> (ø)
ts/config.ts 93.93% <100%> (ø)
ts/store/actions/backendStatus.ts 100% <100%> (ø)
ts/store/reducers/appState.ts 100% <100%> (ø)
ts/sagas/startup/loadSessionInformationSaga.ts 57.14% <33.33%> (ø)
ts/api/backendPublic.ts 33.33% <36.36%> (ø)
ts/sagas/backendStatus.ts 46.15% <46.15%> (ø)
ts/store/reducers/backendStatus.ts 70% <70%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8991ec...de34a23. Read the comment docs.

@valentinacala
Copy link
Contributor

@Undermaken I just solved the conflicts within 5fab941.

One question: I see there are 2 forked sagas on the sagas index, backendInfoSaga and backendServiceStatusSaga. Could it be a good idea to collect them on a segment related to backend only? (To avoid two references on the index both about backend)

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Mar 9, 2020

Affected stories

  • 🌟 #171330968: Come APP se lo stato dei servizi ricevuto dal backend contiene degli errori, mostrare una modale informativa

Generated by 🚫 dangerJS

@Undermaken
Copy link
Contributor Author

@Undermaken I just solved the conflicts within 5fab941.

One question: I see there are 2 forked sagas on the sagas index, backendInfoSaga and backendServiceStatusSaga. Could it be a good idea to collect them on a segment related to backend only? (To avoid two references on the index both about backend)

@valentinacala
I created another saga because the scope is different from info one

  • backendInfoSaga retrieves info about backend version and min version app supported
  • backendServiceStatusSaga retrieves info about backend status: alive or dead.

Furthermore they could have different endpoint

  • backendInfoSaga /iobackend/info
  • backendServiceStatusSaga /ioCDN/status

so imho they should be separated cause they have different logic. Anyway if you find other points because they should be together, we can talk about them

@Undermaken Undermaken merged commit e08e550 into master Mar 30, 2020
@Undermaken Undermaken deleted the 171330968-modal-for-current-services-status branch March 30, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants