Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-625] Add guest payment flow to the new wallet section #5686

Merged
merged 94 commits into from
Apr 23, 2024

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Apr 12, 2024

Short description

This PR introduces the guest payment flow, allowing an user to pay with a payment method not saved in its wallet.

List of changes proposed in this pull request

  • Refactoring/reorganization of payment checkout actions
  • Moved PSP sorting/selection logic from sagas to reducer
  • Add guest payment method fetch in payment methods screen
  • Removed "missing payment methods" error screen

How to test

You can test this PR on both local and UAT environments:

  • Local
    Checkout this PR on io-dev-api-server: Update pagoPA API definitions io-dev-api-server#363
    Start a payment flow and select a payment method not saved to your wallet.
  • UAT
    Start a payment flow using this data:
    • Payment number: 30200000##########
    • Fiscal code: 77777777777

You should be able to finalize a payment.

Preview

RocketSim_Recording_iPhone_14_6.1_2024-04-15_14.54.09.mp4

mastro993 and others added 30 commits March 29, 2024 16:36
…g-screen' into IOBP-563-add-payments-screen-empty-states
@mastro993 mastro993 marked this pull request as ready for review April 18, 2024 13:18
Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mastro993 mastro993 merged commit be75399 into master Apr 23, 2024
11 checks passed
@mastro993 mastro993 deleted the IOBP-625-add-guest-pagopa-payment-flow branch April 23, 2024 08:58
adelloste added a commit that referenced this pull request Apr 23, 2024
This PR depends on #5686,
#5702

## Short description
This PR adds the new list of national institutions.

<details open><summary>Details</summary>
<p>

| institutions  | 
| - |
| <video
src="https://github.com/pagopa/io-app/assets/29163287/dfd8dd19-17c0-4aa4-b04f-292a77854220"
width="300"/> |

</p>
</details> 

## List of changes proposed in this pull request
- bump the `io-app-design-system` library to `1.36.0`
- added the `ServiceHomeInstitutionList` component
- added the custom hook `useHomeInstitutionsFetcher` to fetch the
paginated list of national institutions
- added tests
- updated langs

## How to test
Using[
io-dev-api-server](pagopa/io-dev-api-server#364),
navigate to the services tab. Check that the screen is displayed
correctly.
shadowsheep1 added a commit that referenced this pull request Apr 29, 2024
## Short description
This PR addresses the redesign of **RootedModal** by adopting the new
DS.

> [!TIP]
> Review Privacy ✅
> Translations ⏳
>
> [![Run e2e
tests](https://github.com/pagopa/io-app/actions/workflows/test-e2e.yml/badge.svg?branch=IOPID-1503-new-ds-on-cie-pin-screen)](https://github.com/pagopa/io-app/actions/workflows/test-e2e.yml)

> [!CAUTION]
> Depends on #5686

<details><summary>Demo</summary>
<p>

| 🤖 a11y | 🍏 a11y | 
| - | - |
| <video
src="https://github.com/pagopa/io-app/assets/16268789/6bb0b4e3-fa40-43ca-b001-ef7c0fcfa4f1"
/> | <video
src="https://github.com/pagopa/io-app/assets/16268789/8910e658-71cc-4544-ab72-288a686371c5"
/> |

| UAT EIC Selection |
| - |
| <video
src="https://github.com/pagopa/io-app/assets/16268789/b479a83f-5db3-48c9-9673-8cc08730120b"
/> |

</p>
</details> 

## List of changes proposed in this pull request
- Use the new `OTPInput` in `CiePinScreen`.
- Remove unused component `CiePinpad`.
- Bump
[io-app-design-system](https://github.com/pagopa/io-app-design-system)
from `1.34.0` to `1.36.1` to use `OTPInput` a11y improvements and to be
able to empty its value from the parent component.


## How to test
Run the app both on Anroid and iOS **physical** devices:
- On `LandingPage` triple tap on **pager-dots** to show the UAT CIE
selection screen. Try the `OTPInput` here. It should work as expected.
- Try to login with CIE (for iOS, you'd previously run `yarn
cie-ios:prod`), and on `CiePinScreen` check that all works as expected.

---------

Co-authored-by: Alice Di Rico <83651704+Ladirico@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Development

Successfully merging this pull request may close these issues.

None yet

5 participants