Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPAE-1090] Add handleFindInstitutions saga #5702

Merged
merged 14 commits into from
Apr 23, 2024

Conversation

adelloste
Copy link
Member

This pr depends on #5701

Short description

This PR adds the saga generator to get paginated institutions.

List of changes proposed in this pull request

  • Added handleFindInstitutions saga
  • Added autogenerated client
  • Added tests

How to test

Tests should be solved properly

@pagopa-github-bot pagopa-github-bot changed the title [IOPAE-1090] Add handleFindInstitutions saga chore: [IOPAE-1090] Add handleFindInstitutions saga Apr 18, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Apr 18, 2024

Affected stories

  • ⚙️ IOPAE-1090: [APP] Implementare saga institutions
    subtask of
    • 🌟 IOPAE-1034: [MVP0] Come cittadino voglio vedere tutta la lista degli enti Nazionali nella sezione Servizi

Generated by 🚫 dangerJS against 71c9c89

@adelloste adelloste marked this pull request as ready for review April 22, 2024 17:43
@adelloste adelloste requested a review from a team as a code owner April 22, 2024 17:43
Copy link
Contributor

@giuseppedipinto giuseppedipinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

{
fiscal_code: "FRLFNC82A04D969A" as OrganizationFiscalCode,
id: "1",
name: "Fornitori"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion (non blocking): define different name for different Institutions

Copy link

dpulls bot commented Apr 23, 2024

🎉 All dependencies have been resolved !

@adelloste adelloste merged commit 2e377cb into master Apr 23, 2024
11 checks passed
@adelloste adelloste deleted the IOPAE-1090-saga-handle-find-institutions branch April 23, 2024 10:21
adelloste added a commit that referenced this pull request Apr 23, 2024
This PR depends on #5686,
#5702

## Short description
This PR adds the new list of national institutions.

<details open><summary>Details</summary>
<p>

| institutions  | 
| - |
| <video
src="https://github.com/pagopa/io-app/assets/29163287/dfd8dd19-17c0-4aa4-b04f-292a77854220"
width="300"/> |

</p>
</details> 

## List of changes proposed in this pull request
- bump the `io-app-design-system` library to `1.36.0`
- added the `ServiceHomeInstitutionList` component
- added the custom hook `useHomeInstitutionsFetcher` to fetch the
paginated list of national institutions
- added tests
- updated langs

## How to test
Using[
io-dev-api-server](pagopa/io-dev-api-server#364),
navigate to the services tab. Check that the screen is displayed
correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants