Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [PE-628] CGN - deactivate button on expired card detail screen #5992

Merged
merged 9 commits into from
Aug 23, 2024

Conversation

freddi301
Copy link
Collaborator

@freddi301 freddi301 commented Jul 18, 2024

Short description

Add deactivate button on expired card detail screen

List of changes proposed in this pull request

  • add i18n key
  • refactor original deactivation button into hook + component
  • create a new button for deactivating (original section not modified to not disrupt existing validations)

How to test

figma

  • you need to have an expired CGN card in your wallet (possibile steps to reproduce)
    • login into the app
    • go to wallet
    • add CGN
    • at this point the server should return { "status" : "EXPIRED", ... } on GET /api/v1/cgn/status
  • login into the app
  • go to you wallet
  • go to CGN card
  • at this point there should be an alert stating that the card is expired and the new button for deactivating the card should be there

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 18, 2024

Affected stories

  • 🌟 PE-628: [App] inserimento cta di disattivazione carta in schermata dettaglio carta CGN SCADUTA
    subtask of
    • PE-612: CGN - Review content app

Generated by 🚫 dangerJS against 17386a5

@freddi301 freddi301 changed the title add remove expiored cgn card button feat: [PE-628] CGN - deactivate button on expired card detail screen Jul 18, 2024
@freddi301 freddi301 added Carta Giovani Nazionale copy review needed ✋🏼 🖊️ Awaiting copy review by UX Writers. Don't merge if there is this label. labels Jul 18, 2024
@freddi301
Copy link
Collaborator Author

@mariateresaventura

@freddi301 freddi301 marked this pull request as ready for review July 18, 2024 13:57
@freddi301 freddi301 requested review from thisisjp and a team as code owners July 18, 2024 13:57
@freddi301
Copy link
Collaborator Author

for the reviewer, please fait for copy review, do not merge master into this branch yet

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 47.75%. Comparing base (4f204b4) to head (17386a5).
Report is 412 commits behind head on master.

Files Patch % Lines
ts/features/bonus/cgn/screens/CgnDetailScreen.tsx 0.00% 25 Missing ⚠️
ts/features/bonus/cgn/hooks/useCgnUnsubscribe.tsx 0.00% 17 Missing ⚠️
...res/bonus/cgn/components/detail/CgnUnsubscribe.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5992      +/-   ##
==========================================
- Coverage   48.42%   47.75%   -0.68%     
==========================================
  Files        1488     1717     +229     
  Lines       31617    34483    +2866     
  Branches     7669     8328     +659     
==========================================
+ Hits        15311    16466    +1155     
- Misses      16238    17956    +1718     
+ Partials       68       61       -7     
Files Coverage Δ
...res/bonus/cgn/components/detail/CgnUnsubscribe.tsx 33.33% <0.00%> (+27.08%) ⬆️
ts/features/bonus/cgn/hooks/useCgnUnsubscribe.tsx 0.00% <0.00%> (ø)
ts/features/bonus/cgn/screens/CgnDetailScreen.tsx 8.53% <0.00%> (-5.42%) ⬇️

... and 1162 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea4c74b...17386a5. Read the comment docs.

@mariateresaventura mariateresaventura removed the copy review needed ✋🏼 🖊️ Awaiting copy review by UX Writers. Don't merge if there is this label. label Jul 30, 2024
@mariateresaventura
Copy link
Contributor

@mariateresaventura

Done!

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hantex9 Hantex9 merged commit 10738b2 into master Aug 23, 2024
13 checks passed
@Hantex9 Hantex9 deleted the PE-628-cgn-expired-card-deactivate-button branch August 23, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants