Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-800] Replace from ultra wide camera to wide camera in barcode screen #6057

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Jul 29, 2024

Short description

This PR changes the camera type in the barcode camera screen from ultra-wide-camera to wide-camera

List of changes proposed in this pull request

  • Changed the physicalDevices attribute setting the wide angle camera

How to test

  • Run the app on your device that supports an ultra-wide camera
  • Enable the FF with the new Scan tab from the profile settings;
  • Tap on the Scan tab
  • You should be able to see a wide camera instead of the ultra-wide

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 29, 2024

Affected stories

  • ⚙️ IOBP-800: Impostare schermata wide e non ultra-wide per la scansione barcode

Generated by 🚫 dangerJS against 11a10c8

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.68%. Comparing base (4f204b4) to head (11a10c8).
Report is 416 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6057      +/-   ##
==========================================
- Coverage   48.42%   47.68%   -0.75%     
==========================================
  Files        1488     1720     +232     
  Lines       31617    34742    +3125     
  Branches     7669     8313     +644     
==========================================
+ Hits        15311    16565    +1254     
- Misses      16238    18116    +1878     
+ Partials       68       61       -7     
Files Coverage Δ
...atures/barcode/hooks/useIOBarcodeCameraScanner.tsx 15.49% <ø> (-1.85%) ⬇️

... and 1175 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d66e918...11a10c8. Read the comment docs.

Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hantex9 Hantex9 merged commit 6f9ea7d into master Aug 28, 2024
13 checks passed
@Hantex9 Hantex9 deleted the IOBP-800-set-wide-camera-to-barcode-screen branch August 28, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants