-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [IOBP-797] Hide total amount label if total amount not present #6070
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6070 +/- ##
==========================================
- Coverage 48.42% 47.78% -0.65%
==========================================
Files 1488 1714 +226
Lines 31617 34370 +2753
Branches 7669 8291 +622
==========================================
+ Hits 15311 16423 +1112
- Misses 16238 17886 +1648
+ Partials 68 61 -7
... and 1159 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
...ures/payments/bizEventsTransaction/components/PaymentsBizEventsTransactionHeadingSection.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…/github.com/pagopa/io-app into IOBP-797-hide-total-label-when-not-provided
Short description
This PR hides the "total amount" label if the gran total is not provided by the backend;
List of changes proposed in this pull request
PaymentsBizEventsTransactionTotalAmount
component that is used to render the gran total amount;How to test
You should open a transaction of any payment and check that the total amount label is provided only and only if there is even the amount on the right and if it is not present, that label should not be visible anymore