Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOBP-797] Hide total amount label if total amount not present #6070

Merged
merged 8 commits into from
Aug 2, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Jul 31, 2024

Short description

This PR hides the "total amount" label if the gran total is not provided by the backend;

List of changes proposed in this pull request

  • Added a conditional render to the PaymentsBizEventsTransactionTotalAmount component that is used to render the gran total amount;

How to test

You should open a transaction of any payment and check that the total amount label is provided only and only if there is even the amount on the right and if it is not present, that label should not be visible anymore

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 31, 2024

Affected stories

  • 🐞 IOBP-797: Togliere label "totale" dalle ricevute in cui non c'è il grand total

Generated by 🚫 dangerJS against f12daff

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.78%. Comparing base (4f204b4) to head (f12daff).
Report is 391 commits behind head on master.

Files Patch % Lines
...nts/PaymentsBizEventsTransactionHeadingSection.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6070      +/-   ##
==========================================
- Coverage   48.42%   47.78%   -0.65%     
==========================================
  Files        1488     1714     +226     
  Lines       31617    34370    +2753     
  Branches     7669     8291     +622     
==========================================
+ Hits        15311    16423    +1112     
- Misses      16238    17886    +1648     
+ Partials       68       61       -7     
Files Coverage Δ
...tures/payments/bizEventsTransaction/utils/index.ts 70.73% <100.00%> (ø)
...nts/PaymentsBizEventsTransactionHeadingSection.tsx 4.00% <0.00%> (ø)

... and 1159 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d7271d...f12daff. Read the comment docs.

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hantex9 Hantex9 merged commit e30f8f5 into master Aug 2, 2024
13 checks passed
@Hantex9 Hantex9 deleted the IOBP-797-hide-total-label-when-not-provided branch August 2, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants