Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add expired card in wallet #361

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

mastro993
Copy link
Contributor

Short description

This PR adds an expired payment method in the wallet payload

@mastro993 mastro993 requested a review from a team as a code owner April 9, 2024 09:05
@mastro993 mastro993 changed the title chore: add expired card in wallert chore: add expired card in wallet Apr 9, 2024
Copy link
Contributor

@forrest57 forrest57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993 mastro993 merged commit 3c10a43 into master Apr 12, 2024
6 checks passed
@mastro993 mastro993 deleted the add-expired-card-in-wallet branch April 12, 2024 20:51
mastro993 added a commit to pagopa/io-app that referenced this pull request Apr 15, 2024
> [!WARNING]
> This PR depends on #5663,
pagopa/io-dev-api-server#361

## Short description
This PR adds the error state to payment cards which are expired.

## List of changes proposed in this pull request
- Removed `isError` from `PaymentCardSmallProps`, which is now based on
payment expiry date.

## How to test
With the` io-dev-api-server`, checkout this PR
pagopa/io-dev-api-server#361, enable the **New
wallet section** FF from the profile screen in the IO app.
Check that in the payments landing screen you can see an error card.

## Preview

<img
src="https://github.com/pagopa/io-app/assets/6160324/4888a16a-1ce5-4b83-a440-41f73908c593"
width="250" />

---------

Co-authored-by: Martino Cesari Tomba <60693085+forrest57@users.noreply.github.com>
Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants