[IOBP-563, IOBP-612] Add empty states and navigation events to PaymentsHomeScreen
#5663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yments-landing-screen
…g-screen' into IOBP-563-add-payments-screen-empty-states
…g-screen' into IOBP-563-add-payments-screen-empty-states
|
🎉 All dependencies have been resolved ! |
hevelius
requested changes
Apr 12, 2024
ts/features/payments/home/components/PaymentsHomeEmptyScreenContent.tsx
Outdated
Show resolved
Hide resolved
ts/features/payments/home/components/PaymentsHomeEmptyScreenContent.tsx
Outdated
Show resolved
Hide resolved
hevelius
approved these changes
Apr 12, 2024
CrisTofani
pushed a commit
that referenced
this pull request
Apr 12, 2024
…ntsHomeScreen` (#5663) > [!WARNING] > This PR depends on #5659 This PR introduces empty states and navigation events within the new payments landing screen - Simplified `PaymentCardSmall` and `PaymentCardCarousel` components - Added empty states to `PaymentHomeScreen` - Added store reducer, actions and migration to manage empty methods banner visibility persistence - Added navigation events to `PaymentHomeScreen` components - Added unit tests - Added missing locale keys - Added payload to `paymentsDeleteMethodAction.success` in order to remove the wallet from the list once deleted successfully Static check should solve correctly. With the `io-dev-api-server`, enable te **New wallet section** from the **Profile** screen. Try to simulate different states by mocking api-server responses (`GET /ecommerce/wallets` and `GET /wallet/v1/transactions`). Check that the screen is rendered like in the previews below. | | **w/o payment methods** | **w/ payment methods** | |----------------------|--------------------------|-------------------------| | **w/o transactions** | <img src="https://github.com/pagopa/io-app/assets/6160324/58057e3e-ef51-4f02-bc3a-4bbbf24cc199" width="150" /> | <img src="https://github.com/pagopa/io-app/assets/6160324/afd1c408-5d9a-48a6-a13e-e5967e2817a2" width="150" /> | | **w/ transactions** | <img src="https://github.com/pagopa/io-app/assets/6160324/b4c5e6b8-3b7e-42fc-b6a5-03f8a907616d" width="150" /> | <img src="https://github.com/pagopa/io-app/assets/6160324/9881b73f-a7b2-415c-b3ca-512ee80a3ab0" width="150" /> | --------- Co-authored-by: Martino Cesari Tomba <60693085+forrest57@users.noreply.github.com> Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
dhinterlechner
added a commit
to dhinterlechner/io-app
that referenced
this pull request
Apr 14, 2024
mastro993
added a commit
that referenced
this pull request
Apr 15, 2024
> [!WARNING] > This PR depends on #5663, pagopa/io-dev-api-server#361 ## Short description This PR adds the error state to payment cards which are expired. ## List of changes proposed in this pull request - Removed `isError` from `PaymentCardSmallProps`, which is now based on payment expiry date. ## How to test With the` io-dev-api-server`, checkout this PR pagopa/io-dev-api-server#361, enable the **New wallet section** FF from the profile screen in the IO app. Check that in the payments landing screen you can see an error card. ## Preview <img src="https://github.com/pagopa/io-app/assets/6160324/4888a16a-1ce5-4b83-a440-41f73908c593" width="250" /> --------- Co-authored-by: Martino Cesari Tomba <60693085+forrest57@users.noreply.github.com> Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This PR depends on #5659
Short description
This PR introduces empty states and navigation events within the new payments landing screen
List of changes proposed in this pull request
PaymentCardSmallandPaymentCardCarouselcomponentsPaymentHomeScreenPaymentHomeScreencomponentspaymentsDeleteMethodAction.successin order to remove the wallet from the list once deleted successfullyHow to test
Static check should solve correctly.
With the
io-dev-api-server, enable te New wallet section from the Profile screen.Try to simulate different states by mocking api-server responses (
GET /ecommerce/walletsandGET /wallet/v1/transactions). Check that the screen is rendered like in the previews below.Preview