chore: [IOBP-617] Add expired state to payment card component #5674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yments-landing-screen
…g-screen' into IOBP-563-add-payments-screen-empty-states
…yments-landing-screen
…yments-landing-screen
…g-screen' into IOBP-563-add-payments-screen-empty-states
…7-add-expired-state-to-payment-card-component
|
🎉 All dependencies have been resolved ! |
forrest57
reviewed
Apr 12, 2024
ts/utils/dates.ts
Outdated
| export const isExpiredDate = (expiryDate: string): boolean => { | ||
| const year = +expiryDate.slice(0, 4); | ||
| const month = +expiryDate.slice(4, 6); | ||
| export const isExpiredDate = (expiryDate: Date): boolean => { | ||
| const now = new Date(); | ||
| const nowYearMonth = new Date(now.getFullYear(), now.getMonth() + 1); |
There was a problem hiding this comment.
a payment method expiring this exact month will be set as expired, if this is not intended I believe it is because of the Date.getMonth method, which returns a zero-indexed month
There was a problem hiding this comment.
You are right. The + 1 here should be removed because we already subtract 1 from the month in the getDateFromExpiryDate function.
Fixed and I've also added some tests!
See here 2f82776
hevelius
approved these changes
Apr 15, 2024
mastro993
deleted the
IOBP-617-add-expired-state-to-payment-card-component
branch
mastro993
added a commit
that referenced
this pull request
Apr 16, 2024
…ods (#5680) > [!WARNING] > This PR depends on #5674, pagopa/io-dev-api-server#363 ## Short description This PR adds the `ONBOARDABLE` filter for the payment methods usable for the onboarding ## List of changes proposed in this pull request - Updated pagoPA wallet and ecommerce API definitions - Added `ONBOARDABLE` filter to the payment methods selector ## How to test In an UAT environment, start a payment method onboarding flow. In the payment method selection screen you should be able to see only `ONBOARDABLE` methods --------- Co-authored-by: Martino Cesari Tomba <60693085+forrest57@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This PR depends on #5663, pagopa/io-dev-api-server#361
Short description
This PR adds the error state to payment cards which are expired.
List of changes proposed in this pull request
isErrorfromPaymentCardSmallProps, which is now based on payment expiry date.How to test
With the
io-dev-api-server, checkout this PR pagopa/io-dev-api-server#361, enable the New wallet section FF from the profile screen in the IO app.Check that in the payments landing screen you can see an error card.
Preview