-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Dependency Management RFC 0005: New jam update-dependencies
#104
Comments
buildpack.toml
jam update-dependencies
Maybe it's possible for
|
I love that suggestion @fg-j ! I prefer that suggestion over making a new command and eventually retiring the existing one. |
Agree! |
Per Dependency Management RFC Phase 2, part of the new dependency update workflow there is an "assembly" step in which new dependency versions and metadata get added to the
buildpack.toml
.This issue is to create a new
jam
command, which will eventually replace the existentjam update-dependencies
command to update thebuildpack.toml
. The command will be extremely similar in that it will update thebuildpack.toml
, but it will no longer query the dep-server for metadata, and will instead receive ametadata.json
.A key difference is that it will expect that the metadata provided has already been checked against existent
buildpack.toml
versions and the version constraints. This means, the main job of the command is to take all of the new versions to be added, and appropriately sub them into thebuildpack.toml
to satisfy constraints (like number of patches for a version line).Check out the RFC for details about what the command should do, and how it should fit into the future dependency update workflows.
Note that the new command cannot immediately replacejam update-dependencies
because the old command will be needed for a period of time until migration to the new dependency management strategy is complete. The new command will need to be given a different name for the time being in order to avoid breakages in our current process.Acceptance Criteria
I package up the version of
jam
on the related PR and:The
jam update-dependencies --buildpack-file <path to buildpack.toml>
command still works the same way as it does now, it will use the dep-server to update the buildpack.toml.The
jam update-dependencies
command can also take in ametadata-file
argument, which must be the path to a JSON file containing metadata as outlined in the RFC.stacks
. In this case thejam update-dependencies
command adds both entries to the buildpack.toml. See this metadata file as an example, which can be used alongside this example buildpack.toml file.The text was updated successfully, but these errors were encountered: