Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a platform-dependent dependency mapping #3

Closed
nebhale opened this issue Jul 7, 2020 · 2 comments · Fixed by #4
Closed

Support a platform-dependent dependency mapping #3

nebhale opened this issue Jul 7, 2020 · 2 comments · Fixed by #4
Assignees

Comments

@nebhale
Copy link
Member

nebhale commented Jul 7, 2020

Currently, online packaged buildpacks must download their contributed dependency from the open internet. There are situations where the URIs for those download locations are blocked from within a corporate network. libpack's DependencyCache should noticed the existence of an artifact or artifacts in /platform that defines a mapping between a buildpack's dependency (id/version) and a different URL that it should be downloaded from. This should happen transparently (save for a different log message) to both the buildpack author using DependencyCache and the application developer using a buildpack that uses DependencyCache.

@nebhale
Copy link
Member Author

nebhale commented Jul 14, 2020

ConfigMap with entry-per-buildpack, TOML array per dependency.

[[mapping]]
id = "jdk"
version = "8.0.242"
uri = "https://internal:8080/jdk8.tar.gz
[[mapping]]
id = "jdk"
version = "11.0.6"
uri = "https://internal:8080/jdk11.tar.gz
[[mapping]]
id = "jre"
version = "8.0.242"
uri = "https://internal:8080/jre8.tar.gz
[[mapping]]
id = "jre"
version = "11.0.6"
uri = "https://internal:8080/jre11.tar.gz

@nebhale
Copy link
Member Author

nebhale commented Jul 14, 2020

@ekcasey You're looking for DependencyResolver and you'll want a single log message when you detect this directory. A single line mentioning that you're using platform overrides for downloading, and then the URIs will reflect that in their normal log message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants