Buildpack should only run "npm install" #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it set the start cmd as "npm start", and marked the layers launch/build/cache without considering the metadata passed to it by the downstream consumer. This follows the proposal in [Nodejs RFC 0001](https://github.com/paketo-buildpacks/nodejs/blob/main/rfcs/0001-buildpacks-architecture.md) Co-Authored-by: Arjun Sreedharan <asreedharan@vmware.com> Co-Authored-by: Tim Hitchener <thitchener@vmware.com>
thitch97
approved these changes
Sep 10, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it set the start cmd as "npm start",
and marked the layers launch/build/cache without
considering the metadata passed to it by the downstream
consumer.
This follows the proposal in
Nodejs RFC
0001
Co-Authored-by: Arjun Sreedharan asreedharan@vmware.com
Co-Authored-by: Tim Hitchener thitchener@vmware.com
Resolves #109