Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton does not hide icons #2176

Closed
univerio opened this issue Feb 23, 2018 · 1 comment
Closed

Skeleton does not hide icons #2176

univerio opened this issue Feb 23, 2018 · 1 comment
Assignees
Milestone

Comments

@univerio
Copy link

Bug report

  • Package version(s): 1.35.5, 2.0.0-rc.2
  • Browser and OS versions: Linux, Chrome 64

Steps to reproduce

<button type="button" class="pt-button pt-skeleton pt-icon-cog" tabindex="-1">Submit</button>

Actual behavior

image

Expected behavior

image

Proposed patch

diff --git packages/core/src/components/skeleton/_skeleton.scss packages/core/src/components/skeleton/_skeleton.scss
index 1b44d320..1d64f8aa 100644
--- packages/core/src/components/skeleton/_skeleton.scss
+++ packages/core/src/components/skeleton/_skeleton.scss
@@ -52,5 +52,16 @@ Styleguide pt-skeleton
   animation: $skeleton-animation;
   pointer-events: none;
   user-select: none;
+
+  // hide icon font icons
+  &[class*="pt-icon-"]::before,
+  [class*="pt-icon-"]::before {
+    color: transparent !important;
+  }
+
+  // hide SVG icons
+  * {
+    visibility: hidden !important;
+  }
 }
 /* stylelint-enable declaration-no-important */

Happy to submit a PR.

@llorca
Copy link
Contributor

llorca commented Feb 23, 2018

@univerio we'd gladly take a PR for this. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants