Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive tags with intent have wrong background color when active #6003

Closed
adidahiya opened this issue Mar 7, 2023 · 1 comment · Fixed by #6014
Closed

Interactive tags with intent have wrong background color when active #6003

adidahiya opened this issue Mar 7, 2023 · 1 comment · Fixed by #6014

Comments

@adidahiya
Copy link
Contributor

adidahiya commented Mar 7, 2023

Environment

  • Package version(s): core v4.17.4
  • Operating System: macOS
  • Browser name and version: Chrome

Code Sandbox

https://codesandbox.io/s/cool-perlman-5ewi58?file=/src/Popover2Example.tsx

Steps to reproduce

Render a tag with <Tag interactive={true} active={true} intent="warning">Some text</Tag>

OR

Render an uncontrolled Popover2 with a <Tag interactive={true} intent="warning"> child

Actual behavior

Background color is dark gray

image

2023-03-07 09 50 01

Also triggered when an uncontrolled Popover2 opens:

2023-03-07 09 52 00

Expected behavior

Background color should be slightly darker orange / brown

Possible solution

  1. fix Tag styles when interactive & active modifiers are both enabled
  2. add "Active" prop option to Tag example in docs
@adidahiya
Copy link
Contributor Author

This might be an easy fix, possibly as simple as changing this line:

to be:

&:active,
&.#{$ns}-active {

so that it has sufficient specificity to override these lines:

&:active,
&.#{$ns}-active {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant