Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Toast] Really long strings in toast messages break layout #762

Closed
adidahiya opened this issue Mar 2, 2017 · 1 comment · Fixed by #3634
Closed

[Toast] Really long strings in toast messages break layout #762

adidahiya opened this issue Mar 2, 2017 · 1 comment · Fixed by #3634
Labels
good first issue help wanted Package: core Type: bug
Milestone
3.17.0

Comments

@adidahiya
Copy link
Contributor

Bug report

  • Package version(s): 1.10.0
  • Browser and OS versions: Chrome/OSX

Steps to reproduce

Use a really long string without any whitespace in the body of a toast mesasge

Actual behavior

image

Expected behavior

Not 100% sure... maybe we can change some whitespace or line breaking CSS to make this work
@michael-yx-wu michael-yx-wu mentioned this issue Mar 3, 2017
Closed
@michael-yx-wu
Copy link
Contributor

would word-break: break-all; white-space: break-word be enough to forcibly break long words and wrap normal words?

@cmslewis cmslewis changed the title Really long strings in toast messages break layout [Toast] Really long strings in toast messages break layout Jun 30, 2017
@giladgray giladgray added this to the 2.x milestone Mar 21, 2018
@giladgray giladgray modified the milestones: 2.x, 3.0 Apr 3, 2018
@llorca llorca modified the milestones: 3.0.0, 3.1.0 May 21, 2018
@llorca llorca self-assigned this May 21, 2018
@adidahiya adidahiya modified the milestones: 3.1.0, next Mar 8, 2019
@jdpaterson jdpaterson mentioned this issue Jul 1, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted Package: core Type: bug
Projects
None yet
Milestone
3.17.0
Development

Successfully merging a pull request may close this issue.

[core] fix(Toast): long words in toast messages no longer break container layout
4 participants
@llorca @giladgray @adidahiya @michael-yx-wu