Tests with @Rule still use JUnit 4 vintage #2605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report metrics when unusually large strings are parsed
[skip ci]
InstrumentedJsonFactory sets the expected 'JSON' format name
[skip ci]
Json parser string length metrics are tagged by format
[skip ci]
Increase string-length observability thresholds
[skip ci]
Upgrade Undertow to 2.2.24.Final
Interning introduces excessive contention
[skip ci]
Add public JsonFactory factories to ObjectMappers
[skip ci]
Use a TypeFactory backed by a Caffeine Cache
[skip ci]
Add TypeFactory cache instrumentation
[skip ci]
#2595) Opt out of the TypeFactory cache until we can resolve cache contention
[skip ci]
…ing TypeFactories (#2597) ObjectMappers.withDefaultModules(ObjectMapper) does not replace existing TypeFactories with state from registered modules
[skip ci]
…2601) Apply a large StreamReadConstraints maxStringLength to reduce friction in preparation for jackson 2.15 adoption
[skip ci]
Opt out of canonicalization in Conjure JsonFactories
[skip ci]
carterkozak
reviewed
Apr 27, 2023
| improvement: | ||
| description: Json parser string length metrics are tagged by format | ||
| links: | ||
| - https://github.com/palantir/conjure-java-runtime/pull/2571 |
There was a problem hiding this comment.
Looks like something went sideways in a rebase/merge
There was a problem hiding this comment.
Ugh, the merge of origin/develop seems to have gone sideways, I may just put together a separate PR
Merged
|
Moving to #2616 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
JUnit 5 excavator #2485 is stuck.
2093 tests complete on
developcheck taskAfter this PR
Merged origin/develop into this branch and updated tests still using
@Ruleto still use JUnit 4 vintage. This is a smaller change than #2495 that completely eradicates JUnit 4, so targeting this sooner to unblock excavator.2093 tests complete on this branch's
checktask==COMMIT_MSG==
Tests with @rule still use JUnit 4 vintage
==COMMIT_MSG==
Possible downsides?