Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make automatic project version tag optional #567

Closed
fletch3555 opened this issue Jun 7, 2022 · 1 comment
Closed

Make automatic project version tag optional #567

fletch3555 opened this issue Jun 7, 2022 · 1 comment

Comments

@fletch3555
Copy link

What happened?

When building an image, this plugin will automatically append the project version to the list of tags (ref: https://github.com/palantir/gradle-docker/blob/develop/src/main/groovy/com/palantir/gradle/docker/DockerExtension.groovy#L98).

What did you want to happen?

I plan to add tags conditionally, so I need this to not happen automatically, or at least a way to disable it.

I would suggest the best user experience would be for the ONLY automatic tag to be the one matching the required "name" property, whether that's implicit ("latest") or provided explicitly.

I'll gladly open a PR for this if there's consensus. Thanks!

@fletch3555
Copy link
Author

Apologies, this is a duplicate of #516. Not sure how I didn't see it before.

@fletch3555 fletch3555 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant