Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #515 don't ignore LSP client's snippet support capabilities #526

Closed
wants to merge 3 commits into from
Closed

Fix #515 don't ignore LSP client's snippet support capabilities #526

wants to merge 3 commits into from

Conversation

Shougo
Copy link

@Shougo Shougo commented Mar 16, 2019

Fix #515

@palantirtech
Copy link
Member

Thanks for your interest in palantir/python-language-server, @Shougo! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@Shougo
Copy link
Author

Shougo commented Mar 16, 2019

Please test it.

This was referenced Mar 16, 2019
Merged
Closed
@hujianxin
Copy link

Tested it, works fine

@fominok
Copy link

fominok commented Mar 20, 2019

Really looking forward to this merge

@Shougo
Copy link
Author

Shougo commented Mar 21, 2019

I have fixed unit tests.

@lambdacn
Copy link

ping @palantirtech

@lambdacn
Copy link

I think this pr should be merged.

@fominok
Copy link

fominok commented Mar 23, 2019

ping @gatesn

@gatesn gatesn mentioned this pull request Mar 27, 2019
Merged
@gatesn
Copy link
Contributor

gatesn commented Mar 27, 2019

Apologies, I've been out on vacation. For expediency, I've made a few changes to this PR here: #529. Namely, the jedi setting for enabling snippets doesn't override what client capabilities say; and snippets are only generated for positional arguments.

@gatesn gatesn closed this Mar 27, 2019
gatesn added a commit that referenced this pull request Mar 27, 2019
@gatesn
Respect client capabilities snippet support (#529)
dfff3c9 
Fixes #515 
Fixes #526 

Also only generates snippets for positional args
@sevaho sevaho mentioned this pull request Mar 27, 2019
Closed
@Shougo
Copy link
Author

Shougo commented Mar 28, 2019

OK.

@Shougo Shougo deleted the snippet_support branch March 28, 2019 01:01
joaotavora added a commit to joaotavora/python-language-server that referenced this pull request Oct 11, 2019
@joaotavora
If client declares supports, provide snippet completions by default
6ce6124 
This is the way python-language-server used to work before palantir#519.  This
shouldn't conflict with the goals of palantir#515 of palantir#526, i.e. if the client
does _not_ declare support for snippets, none are sent.

* pyls/plugins/jedi_completion.py (pyls_completions): Default
should_include_params to True, like before.
@joaotavora joaotavora mentioned this pull request Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Shougo @palantirtech @hujianxin @fominok @lambdacn @gatesn