Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Feb 15, 2019

Fixes #496

@gatesn gatesn merged commit ee71c1d into develop Feb 15, 2019
@gatesn gatesn deleted the ngates/snippet-completion branch February 15, 2019 12:12
@dbarrosop
Copy link

I think you should consider disabling this by default and/or documenting in the README how to disable it. This feature is extremely disruptive when coding.

@vv111y
Copy link

vv111y commented Mar 13, 2019

I would like to chime in too. It's a great idea in theory, and I am grateful for your effort and thoughtfulness. It has the potential to become very useful but right now it's really bad.
Pretty much 100% of my completions I only use a fraction of the arguments. I basically just delete line from cursor, and then I manually enter the rest of the function call.
It would be good to have a switch to disable, and maybe later to have customization options.

@gatesn
Copy link
Contributor Author

gatesn commented Mar 13, 2019

Yup completely agree. Do you think inserting only positional arguments is the right thing, and not optional keyword arguments? Or just disabling entirely?

@Shougo
Copy link

Shougo commented Mar 16, 2019

#526

I think it is the right fix.

@vv111y
Copy link

vv111y commented Mar 17, 2019

Sorry for delay,
I think both: 1) disable option, 2) positional arguments option.
Another nice option is to have keyword args be available via autocomplete, if you need them, then this cuts down on typing, if not, then just ignore and escape out of the parentheses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants