Update Jedi calls for its 0.17.0+ API #781

bnavigator · 2020-04-16T10:04:49Z

As discussed in #744 (comment), fixes #744, including most recent Jedi 0.17.0

~~This is a combination of #775 and dalthviz#1~~ Edit: removed the jedi master branch pulls in the CIs

Signed-off-by: Morten Linderud <morten@linderud.pw>

fix path and project parameters for jedi_script remove deprecated usages() calls

source is deprecated in 0.17.0 in favor of code but code did not exist in 0.16.0

sometimes jedi reports some keywords first

ccordoba12

@bnavigator, as part of this PR please also remove the code that tried to support Jedi 0.14 because it no longer applies (please look for JEDI_VERSION to do do that).

setup.py

ccordoba12 · 2020-04-16T19:24:39Z

Thanks a lot @bnavigator for your help with this one! I'll review it tomorrow (I don't have time today, sorry).

goanpeca · 2020-04-18T12:37:38Z

Thanks a lot for this @bnavigator!!

goanpeca · 2020-04-24T00:00:34Z

IS this ready @ccordoba12 ?

E1k3 · 2020-04-29T16:41:15Z

Is there any update on this or is there any way to help finalizing this pull request?

ccordoba12 · 2020-04-29T17:32:16Z

IS this ready @ccordoba12 ?

I haven't had time to review it. Please help me with that and let me know if you need additional help.

E1k3

The changes seem good to me. The changes from davidhalter/jedi#1063 (comment) are accounted for and the new Project feature of jedi 0.17 is used.

I will now test this branch with vim + asyncomplete + vim-lsp for definition, hover, completion, references and signature. As far as I know, highlights are not implemented for this client, yet.

pyls/plugins/jedi_completion.py

E1k3 · 2020-04-29T20:17:35Z

I have tested all mentioned features in a relatively simple script that imports various modules from Keras, NumPy, SciPy, Argparse and others and pyls worked flawlessly.

@ccordoba12 If more comprehensive testing or more detailed commentary on the changes are needed, please tell me in detail what you need..

@E1k3

Thanks for the review @E1k3

E1k3 · 2020-05-03T23:06:49Z

@ccordoba12 Is there anything to be done with this request despite merging it?

The archlinux package of pyls is currently incompatible with jedi and workarounds are on hold, because this looks finished.

bnavigator · 2020-05-03T23:11:40Z

@E1k3, I recommend you apply the patch directly to the Archlinux package. That's what OpenSUSE is doing.

There may be some burnt ground between @ccordoba12 and me. Chances are, he will never accept this PR despite the clear demand from the community shown by the reactions in this thread and in #744.

goanpeca · 2020-05-04T01:57:24Z

@bnavigator we really appreciate your help with this work. We are a bit crowded right now and in the midst of making a release. Having this PR merged could delay our release or introduce some unwanted bugs with some other libraries introspection.

There may be some burnt ground between @ccordoba12 and me. Chances are, he will never accept this PR despite the clear demand from the community shown by the reactions in this thread and in #744.

We just need to review the PR (I have not found time yet!)

We also probably need to add some simple smoke tests with libraries that have broken with the past versions of Jedi (0.16).

Thanks again for the help!

ccordoba12 · 2020-05-04T02:54:47Z

Chances are, he will never accept this PR despite the clear demand from the community shown by the reactions in this thread and in #744.

This is not true. As @goanpeca said, we are swamped at the moment and haven't had time to review this PR, sorry. We'll try to do it and release 0.32.0 with these changes this week.

ccordoba12 · 2020-05-04T02:56:08Z

We also probably need to add some simple smoke tests with libraries that have broken with the past versions of Jedi (0.16).

I already added tests for Numpy, Pandas and Matplotlib. One of them detected an error in Jedi 0.16, which was fixed in 0.17

bnavigator · 2020-05-09T19:23:46Z

Using _workspace.root_path didn't look like such a great idea.

>       project_path = self._workspace.root_path if self._workspace else os.path.dirname(self.path)
E       AttributeError: 'MockWorkspace' object has no attribute 'root_path'

ccordoba12 · 2020-05-09T19:29:40Z

Ok, on it. I think I know how to fix this.

ccordoba12 · 2020-05-09T19:34:43Z

I don't think your last commit is the right solution @bnavigator. I think the problem is in MockWorkspace.

Could you leave this alone for a few minutes? Thanks!

bnavigator · 2020-05-09T20:14:36Z

If you allow Document(..., workspace=None) you cannot just assume that ._workspace is a workspace.

ccordoba12 · 2020-05-09T20:25:30Z

If you allow Document(..., workspace=None) you cannot just assume that ._workspace is a workspace.

I think it's better to use something that stands for a real Workspace object (I'm almost ready with my fixes).

fsouza · 2020-05-09T20:52:14Z

@ccordoba12 I think what @bnavigator means is that now that workspace is required in Document, it shouldn't be an optional parameter in the constructor. As long as it's optional in the constructor, the code should support the case where it's None, even though in practice this never happens? 🤔

ccordoba12

I think this is finally ready. Thanks everyone (specially @bnavigator) for your patience.

ccordoba12 · 2020-05-09T20:58:10Z

You're totally @bnavigator and @fsouza! I'll do that last change here.

Address last review

bnavigator · 2020-05-09T20:59:47Z

@ccordoba12 I think what @bnavigator means is that now that workspace is required in Document, it shouldn't be an optional parameter in the constructor. As long as it's optional in the constructor, the code should support the case where it's None, even though in practice this never happens?

Thanks for breaking it down @fsouza.

At least in the tests it happens all the time. And these are only the one-liners:

[ben@voyagerS9:~/src/python-language-server]% grep 'Document(.*)' * -R | grep -v workspace                                     [0]
test/fixtures.py:    return Document(DOC_URI, DOC)
test/plugins/test_autopep8_format.py:    doc = Document(DOC_URI, DOC)
test/plugins/test_autopep8_format.py:    doc = Document(DOC_URI, DOC)
test/plugins/test_autopep8_format.py:    doc = Document(DOC_URI, GOOD_DOC)
test/plugins/test_flake8_lint.py:    doc = Document(uris.from_fs_path(name))
test/plugins/test_flake8_lint.py:    doc = Document('', DOC)
test/plugins/test_folding.py:    doc = Document(DOC_URI, DOC)
test/plugins/test_folding.py:    doc = Document(DOC_URI, SYNTAX_ERR)
test/plugins/test_mccabe_lint.py:        doc = Document(DOC_URI, DOC)
test/plugins/test_mccabe_lint.py:    doc = Document(DOC_URI, DOC_SYNTAX_ERR)
test/plugins/test_pycodestyle_lint.py:    doc = Document(DOC_URI, DOC)
test/plugins/test_pydocstyle_lint.py:    doc = Document(DOC_URI, DOC)
test/plugins/test_pydocstyle_lint.py:    doc = Document(TEST_DOC_URI, "")
test/plugins/test_pydocstyle_lint.py:    doc = Document(DOC_URI, "")
test/plugins/test_pydocstyle_lint.py:    doc = Document(DOC_URI, "bad syntax")
test/plugins/test_pyflakes_lint.py:    doc = Document(DOC_URI, DOC)
test/plugins/test_pyflakes_lint.py:    doc = Document(DOC_URI, DOC_SYNTAX_ERR)
test/plugins/test_pyflakes_lint.py:    doc = Document(DOC_URI, DOC_UNDEFINED_NAME_ERR)
test/plugins/test_pyflakes_lint.py:    doc = Document(DOC_URI, DOC_ENCODING)
test/plugins/test_pylint_lint.py:        yield Document(uris.from_fs_path(name))
test/plugins/test_pylint_lint.py:        config, Document(uris.from_fs_path(__file__)), True)
test/plugins/test_pylint_lint.py:        config, Document(uris.from_fs_path(__file__)), False)
test/plugins/test_yapf_format.py:    doc = Document(DOC_URI, DOC)
test/plugins/test_yapf_format.py:    doc = Document(DOC_URI, DOC)
test/plugins/test_yapf_format.py:    doc = Document(DOC_URI, GOOD_DOC)
test/plugins/test_yapf_format.py:    doc = Document(uris.from_fs_path(src.strpath), DOC)
test/plugins/test_completion.py:    doc = Document(DOC_URI, DOC)
test/plugins/test_rope_rename.py:    doc = Document(DOC_URI)
test/test_document.py:    document_mem = Document(DOC_URI, u'my source')
test/test_document.py:    document_disk = Document(DOC_URI)
test/test_document.py:    doc = Document('file:///uri', u'')
test/test_document.py:    doc = Document('file:///uri', u'itshelloworld')
test/test_document.py:    doc = Document('file:///uri', u''.join(old))
test/test_document.py:    doc = Document('file:///uri', u''.join(old))

fsouza

🎉

mattst88 · 2020-05-09T22:47:37Z

Thanks a bunch to everyone involved!

If possible, please tag a release with this included. It'll help downstream Linux distros quite a lot.

polyzen · 2020-05-09T22:57:31Z

https://github.com/palantir/python-language-server/milestone/17

Foxboron · 2020-05-09T23:09:36Z

Thanks for the work getting this fixed :)

pyls/workspace.py

ccordoba12 · 2020-05-13T20:50:21Z

0.32.0 is out.

https://build.opensuse.org/request/show/810112 by user scarabeus_iv + maxlin_factory - Update to Version 0.33.0 * Add optional class objects to completion list. * Fix completions with one arg. * Remove pycodestyle plugin's dependency on autopep8. - Update to Version 0.32.0 * Increase minimal supported version of flake8 and match flake8 requirements to PyLS ones. * Add support for renaming with Jedi. * Update Jedi calls for its 0.17 API * Fix flake8 io deadlock. * Follow LSP protocol when workspace folders are changed. * Adapt root workspace uri if folder is changed. * Add option to activate fuzzy completions in Jedi - remove pach pyls-pr781-jedi-017.patch merged gh#palantir/python-language-server#781 - Bump requirements in spec file

bnavigator mentioned this pull request Apr 16, 2020

Adapt to the last Jedi #744

Closed

Foxboron and others added 7 commits April 16, 2020 12:39

Changed towards jedi 0.16

cb51b09

Signed-off-by: Morten Linderud <morten@linderud.pw>

remove deprecated params call

7ca854b

remove deprecated names call

b1e08e1

convert position into jedi line, column

9e8d7fd

fix path and project parameters for jedi_script remove deprecated usages() calls

jedi.Script keywords source vs code

16a526b

source is deprecated in 0.17.0 in favor of code but code did not exist in 0.16.0

don't expect isabs at first place

551990f

sometimes jedi reports some keywords first

check expected in all refs in builtin test

afafa62

bnavigator mentioned this pull request Apr 16, 2020

Remove deprecated calls for Jedi >= 0.16.0 dalthviz/python-language-server#1

Closed

ccordoba12 reviewed Apr 16, 2020

View reviewed changes

setup.py Outdated Show resolved Hide resolved

ccordoba12 changed the title ~~Update JEDI calls for API >=0.16.0~~ Update Jedi calls for its 0.17.0+ API Apr 16, 2020

bnavigator added 2 commits April 16, 2020 19:10

bump minimum jedi version to 0.17

90e5d45

cleanup unused imports

c38ceb3

skip test_references_builtin for PY2

47e25f7

Mic92 mentioned this pull request Apr 27, 2020

Bump jedi versions (and its dependency parso) NixOS/nixpkgs#86073

Closed

10 tasks

E1k3 approved these changes Apr 29, 2020

View reviewed changes

pyls/plugins/jedi_completion.py Outdated Show resolved Hide resolved

remove TypeError in _detail again

688d4ee

Thanks for the review @E1k3

E1k3 approved these changes May 1, 2020

View reviewed changes

bnavigator mentioned this pull request May 2, 2020

Support for jedi 0.17.0 spyder-ide/spyder#12572

Closed

test for root_path attribute in jedi_script()

1ad6229

Always use workspace.root_path for Jedi's project path

56a4be5

ccordoba12 added 3 commits May 9, 2020 15:39

Use the workspace fixture to fix failing tests

7debe28

Fix style issue

a079d7f

Merge branch 'develop' into jedi

93b5bef

ccordoba12 previously approved these changes May 9, 2020

View reviewed changes

fsouza approved these changes May 9, 2020

View reviewed changes

ccordoba12 added 3 commits May 9, 2020 17:02

Make workspace a required argument for the Document class

9026ea8

Fix pylint complaint

3da9869

Fix another pyling warning

da659ae

ccordoba12 approved these changes May 9, 2020

View reviewed changes

ccordoba12 added this to the 0.32.0 milestone May 9, 2020

ccordoba12 merged commit 2fb2c81 into palantir:develop May 9, 2020

bnavigator commented May 9, 2020

View reviewed changes

pyls/workspace.py Show resolved Hide resolved

ccordoba12 mentioned this pull request May 11, 2020

Make workspace a required arg when calling Document in Workspace class #806

Merged

bnavigator mentioned this pull request Jan 5, 2021

bump jedi compatibility: compare to Path-like object #901

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Jedi calls for its 0.17.0+ API #781

Update Jedi calls for its 0.17.0+ API #781

bnavigator commented Apr 16, 2020 •

edited

Loading

ccordoba12 left a comment

ccordoba12 commented Apr 16, 2020

goanpeca commented Apr 18, 2020

goanpeca commented Apr 24, 2020

E1k3 commented Apr 29, 2020

ccordoba12 commented Apr 29, 2020

E1k3 left a comment •

edited

Loading

E1k3 commented Apr 29, 2020 •

edited

Loading

E1k3 commented May 3, 2020

bnavigator commented May 3, 2020 •

edited

Loading

goanpeca commented May 4, 2020

ccordoba12 commented May 4, 2020

ccordoba12 commented May 4, 2020

bnavigator commented May 9, 2020

ccordoba12 commented May 9, 2020

ccordoba12 commented May 9, 2020

bnavigator commented May 9, 2020

ccordoba12 commented May 9, 2020

fsouza commented May 9, 2020

ccordoba12 left a comment

ccordoba12 commented May 9, 2020

bnavigator commented May 9, 2020 •

edited

Loading

fsouza left a comment

mattst88 commented May 9, 2020

polyzen commented May 9, 2020

Foxboron commented May 9, 2020

ccordoba12 commented May 13, 2020

Update Jedi calls for its 0.17.0+ API #781

Update Jedi calls for its 0.17.0+ API #781

Conversation

bnavigator commented Apr 16, 2020 • edited Loading

ccordoba12 left a comment

Choose a reason for hiding this comment

ccordoba12 commented Apr 16, 2020

goanpeca commented Apr 18, 2020

goanpeca commented Apr 24, 2020

E1k3 commented Apr 29, 2020

ccordoba12 commented Apr 29, 2020

E1k3 left a comment • edited Loading

Choose a reason for hiding this comment

E1k3 commented Apr 29, 2020 • edited Loading

E1k3 commented May 3, 2020

bnavigator commented May 3, 2020 • edited Loading

goanpeca commented May 4, 2020

ccordoba12 commented May 4, 2020

ccordoba12 commented May 4, 2020

bnavigator commented May 9, 2020

ccordoba12 commented May 9, 2020

ccordoba12 commented May 9, 2020

bnavigator commented May 9, 2020

ccordoba12 commented May 9, 2020

fsouza commented May 9, 2020

ccordoba12 left a comment

Choose a reason for hiding this comment

ccordoba12 commented May 9, 2020

bnavigator commented May 9, 2020 • edited Loading

fsouza left a comment

Choose a reason for hiding this comment

mattst88 commented May 9, 2020

polyzen commented May 9, 2020

Foxboron commented May 9, 2020

ccordoba12 commented May 13, 2020

bnavigator commented Apr 16, 2020 •

edited

Loading

E1k3 left a comment •

edited

Loading

E1k3 commented Apr 29, 2020 •

edited

Loading

bnavigator commented May 3, 2020 •

edited

Loading

bnavigator commented May 9, 2020 •

edited

Loading