Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct method and attribute detection on document/symbols call #846

Merged
merged 11 commits into from
Sep 16, 2020

Conversation

andfoy
Copy link
Contributor

@andfoy andfoy commented Aug 25, 2020

This PR corrects the types of methods and attributes, which were marked as functions and variables by Jedi, respectively

Copy link
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andfoy, great improvement!

@ccordoba12 ccordoba12 added this to the 0.36.0 milestone Sep 16, 2020
@ccordoba12 ccordoba12 changed the title PR: Correct method and attribute detection on document/symbols call Correct method and attribute detection on document/symbols call Sep 16, 2020
@ccordoba12 ccordoba12 merged commit d81c7ba into palantir:develop Sep 16, 2020
@andfoy andfoy deleted the fix_method_attribute_symbols branch September 16, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants