Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest.yml is executable? #48

Closed
bmoylan opened this issue Feb 4, 2016 · 2 comments
Closed

manifest.yml is executable? #48

bmoylan opened this issue Feb 4, 2016 · 2 comments

Comments

@bmoylan
Copy link
Contributor

bmoylan commented Feb 4, 2016

manifest.yml is set to executable. Is there a reason for this line? https://github.com/palantir/gradle-java-distribution/blob/develop/src/main/groovy/com/palantir/gradle/javadist/JavaDistributionPlugin.groovy#L95
@markelliot
Copy link
Contributor

looks like a copy-paste error at some point.

@bmoylan
Copy link
Contributor Author

bmoylan commented Feb 4, 2016

Will have a PR up in a sec. Don't think it needs its own release.

bmoylan added a commit to bmoylan/gradle-java-distribution that referenced this issue Feb 4, 2016
@bmoylan
Drop executable bit on manifest.yml.
9fe642c 
Addresses palantir#48
@bmoylan bmoylan mentioned this issue Feb 4, 2016
Merged
@bmoylan bmoylan closed this as completed Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markelliot @bmoylan