Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liveness endpoint should return non-empty JSON object #271

Open
lycarter opened this issue Mar 24, 2021 · 0 comments
Open

Liveness endpoint should return non-empty JSON object #271

lycarter opened this issue Mar 24, 2021 · 0 comments

Comments

@lycarter
Copy link

lycarter commented Mar 24, 2021

What happened?

Java witchcraft has diverged from the SLS spec and returns a simple "alive" for the liveness endpoint. Consuming services now expect that, while witchcraft-go returns an empty JSON object, which results in some consuming services not considering witchcraft-go services "live"

What did you want to happen?

Witchcraft-go should follow the lead of Java witchcraft and return a non-empty JSON response on the liveness endpoint

(feel free to reach out internally for more context - Lilliput#360)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant