Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sizes can still overflow #19

Closed
jnape opened this issue Apr 27, 2020 · 1 comment
Closed

sizes can still overflow #19

jnape opened this issue Apr 27, 2020 · 1 comment
Assignees
@jnape
Labels
bug
Milestone
alpha-2

Comments

@jnape
Copy link
Member

jnape commented Apr 27, 2020

StrictStack#sizeInfo, for example, calls abs(size(this)); size returns long. This has to use an adder that auto-widens the numeric type; probably BigInteger to be safe.
@jnape jnape added the bug label Apr 27, 2020
@jnape jnape added this to the alpha-2 milestone Apr 27, 2020
@jnape jnape self-assigned this Apr 27, 2020
@jnape
Copy link
Member Author

jnape commented May 8, 2020

Fixed in 1f42fc5

@jnape jnape closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnape jnape

Labels
bug
Projects
None yet
Milestone
alpha-2
Development

No branches or pull requests
1 participant
@jnape