We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a new prop requires some involved changes and writing tests. I have outlined steps to add a new prop below.
DEFAULT_PROPS
Please make sure to add a new test to verify the new changes. Example tests can be referred here - https://github.com/palerdot/react-d3-speedometer/blob/master/src/tests/index.js#L88. Also, refer to enzyme documentation.
yarn lintfix
Please allow edits from maintainers option for me to update docs if PR is in an acceptable state. Please refer - https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Adding a new prop requires some involved changes and writing tests. I have outlined steps to add a new prop below.
Steps for adding prop
DEFAULT_PROPS
- around https://github.com/palerdot/react-d3-speedometer/blob/master/src/core/config/index.js#L67Adding tests:
Please make sure to add a new test to verify the new changes. Example tests can be referred here - https://github.com/palerdot/react-d3-speedometer/blob/master/src/tests/index.js#L88. Also, refer to enzyme documentation.
Important:
yarn lintfix
locally to lint the code as per this project requirements.Miscellaneous:
Please allow edits from maintainers option for me to update docs if PR is in an acceptable state. Please refer - https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
The text was updated successfully, but these errors were encountered: