Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding New props #153

Open
palerdot opened this issue Sep 28, 2022 · 0 comments
Open

Adding New props #153

palerdot opened this issue Sep 28, 2022 · 0 comments

Comments

@palerdot
Copy link
Owner

palerdot commented Sep 28, 2022

Adding a new prop requires some involved changes and writing tests. I have outlined steps to add a new prop below.

Steps for adding prop

Adding tests:

Please make sure to add a new test to verify the new changes. Example tests can be referred here - https://github.com/palerdot/react-d3-speedometer/blob/master/src/tests/index.js#L88. Also, refer to enzyme documentation.

Important:

  • Make sure to add a test case (Please refer above section)
  • Make sure existing tests don't break
  • Make sure the code is linted properly. Run yarn lintfix locally to lint the code as per this project requirements.

Miscellaneous:

Please allow edits from maintainers option for me to update docs if PR is in an acceptable state. Please refer - https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant