Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of ParamSpec only works in Python 3.10+ #90

Closed
luong-komorebi opened this issue Apr 3, 2023 · 3 comments
Closed

Use of ParamSpec only works in Python 3.10+ #90

luong-komorebi opened this issue Apr 3, 2023 · 3 comments

Comments

@luong-komorebi
Copy link

This morning we faced this issue
42580

for a working service that has received no code change in dependencies recently. By tracking the root cause, I was able to detect that it was caused by typing-extension, which was used by blinker, which was part of Flask (our direct dependency). A similar issue with the same footprint could be found here and here. Typing extension didnt include a change log for version < 4 so I cannot track down which version starts this issue.

We either need to do some if else check to ensure that when a combination of packages is used, blinker is able to use paramspec. Another intrusive way is to declare a minimum version for typing extension.

@davidism
Copy link
Member

davidism commented Apr 3, 2023

Another intrusive way is to declare a minimum version for typing extension.

Yes, this is the correct way. It sounds like you already had a version of typing_extensions installed, which was not upgraded when you installed Flask-SQLAlchemy. Since we depend on features from a later version, we should set that minimum version.

@pgjones
Copy link
Member

pgjones commented Apr 9, 2023

I think I'll require ParamSpec > 4.2 (first mention of ParamSpec), and I'll release a 1.6.1 to fix this and the missing py.typed file.

@pgjones
Copy link
Member

pgjones commented Apr 9, 2023

Fixed with 1.6.1, now released.

@pgjones pgjones closed this as completed Apr 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants