Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSession time is too short #21

Closed
viweei opened this issue Sep 20, 2015 · 1 comment
Closed

FileSession time is too short #21

viweei opened this issue Sep 20, 2015 · 1 comment

Comments

@viweei
Copy link

viweei commented Sep 20, 2015

FileSession time is too short, I found in the File

sessions.py at line 297

self.cache = FileSystemCache (cache_dir, threshold = threshold, mode = mode)

Missing parameters default_timeout, because FileSystemCache default value is 300 seconds.
look at

class FileSystemCache(BaseCache):
   """
   ....
   """
    #: used for temporary files by the FileSystemCache
    _fs_transaction_suffix = '.__wz_cache'

    def __init__(self, cache_dir, threshold=500, default_timeout=300, mode=0o600):
        BaseCache.__init__(self, default_timeout)
        self._path = cache_dir
        self._threshold = threshold
        self._mode = mode

So I think we should use Flask parameter "PERMANENT_SESSION_LIFETIME"

@fengsp fengsp closed this as completed Oct 27, 2015
@fengsp
Copy link
Contributor

fengsp commented Oct 27, 2015

We are always using PERMANENT_SESSION_LIFETIME so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants