Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Leak in _winconsole #495

Closed
ibookstein opened this issue Dec 30, 2015 · 1 comment · Fixed by #1136
Closed

Memory Leak in _winconsole #495

ibookstein opened this issue Dec 30, 2015 · 1 comment · Fixed by #1136
Labels
bug windows Issues pertaining to the Windows environment
Milestone
7.1

Comments

@ibookstein
Copy link

Result of call to CommandLineToArgvW should be released by LocalFree.
Should probably also check for failure of that function call (NULL is returned).
@untitaker
Copy link
Contributor

@mitsuhiko Any idea?

@fdavis fdavis added the windows Issues pertaining to the Windows environment label May 15, 2018
segevfiner added a commit to segevfiner/click that referenced this issue Oct 7, 2018
@segevfiner
Fix a memory leak and missing error check in _get_windows_argv
f335578 
Fixes pallets#495
segevfiner added a commit to segevfiner/click that referenced this issue Oct 7, 2018
@segevfiner
Fix a memory leak and missing error check in _get_windows_argv
c86be98 
Fixes pallets#495
@segevfiner segevfiner mentioned this issue Oct 7, 2018
Merged
segevfiner added a commit to segevfiner/click that referenced this issue Oct 7, 2018
@segevfiner
Fix a memory leak and missing error check in _get_windows_argv
f014a47 
Fixes pallets#495
@davidism davidism added this to the 7.1 milestone Feb 23, 2020
@davidism davidism removed the ready label Feb 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug windows Issues pertaining to the Windows environment
Projects
None yet
Milestone
7.1
Development

Successfully merging a pull request may close this issue.

Fix a memory leak and missing error check in _get_windows_argv segevfiner/click
5 participants
@mitsuhiko @untitaker @davidism @fdavis @ibookstein