Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_filename_formatting() fails on Python 3 (Unicode) #96

Closed
aldanor opened this issue May 26, 2014 · 1 comment
Closed

test_filename_formatting() fails on Python 3 (Unicode) #96

aldanor opened this issue May 26, 2014 · 1 comment

Comments

@aldanor
Copy link

aldanor commented May 26, 2014

Running the tests on Python 3.3 / Python 3.4:

    def test_filename_formatting():
        assert click.format_filename(b'foo.txt') == 'foo.txt'
        assert click.format_filename(b'/x/foo.txt') == '/x/foo.txt'
        assert click.format_filename(u'/x/foo.txt') == '/x/foo.txt'
        assert click.format_filename(u'/x/foo.txt', shorten=True) == 'foo.txt'
>       assert click.format_filename('/x/foo\xff.txt', shorten=True) \
            == u'foo\ufffd.txt'
E       assert 'fooÿ.txt' == 'foo�.txt'
E         - fooÿ.txt
E         ?    ^
E         + foo�.txt
E         ?    ^
@mitsuhiko
Copy link
Contributor

There is a good chance that test is broken in the release version. It's definitely fixed in git.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants