Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helpers for Flask's send_file wrapper #1962

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Conversation

davidism
Copy link
Member

@davidism davidism commented Nov 5, 2020

Without these changes, Flask's wrappers would need to duplicate the path processing code. These changes are for internal use only.

  • _root_path private parameter allows paths to be relative to app.root_path instead of cwd.
  • max_age can be a callable that takes an optional path, allows calling app.get_send_file_max_age.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

Without these changes, Flask's wrappers would need to duplicate the
path processing code. These changes are for internal use only.

_root_path private parameter allows paths to be relative to
app.root_path instead of cwd.

max_age can be a callable that takes an optional path, allows
calling app.get_send_file_max_age.
@davidism davidism added this to the 2.0.0 milestone Nov 5, 2020
@davidism davidism merged commit 2db3337 into master Nov 5, 2020
@davidism davidism deleted the send-file-flask-params branch November 5, 2020 15:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant