Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use of hashlib.sha1 causes issue in FIPS build #375

Closed
davidism opened this issue Apr 13, 2024 · 0 comments · Fixed by #378
Closed

use of hashlib.sha1 causes issue in FIPS build #375

davidism opened this issue Apr 13, 2024 · 0 comments · Fixed by #378
Milestone

Comments

@davidism
Copy link
Member

Some FIPS builds are going beyond the standard and disabling SHA-1 (rather than just strongly discouraging its use). ItsDangerous accesses hashlib.sha1 on import in order to set a default, which immediately fails since sha1 isn't available in these builds. Make its access lazy so users have time to override the default. SHA-1 remains safe to use in HMAC, so the default will not be changing.

@davidism davidism added this to the 2.2.0 milestone Apr 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant