Fix debug_info logic to avoid ValueError on empty _debug_info #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most non-user facing.
Trivial typos
Fix typo instanciable > instantiable
Allow to pass a list to native_concat
In Python, it's legal to use splats in function calls like this:
call_function('123', *b, c=5, **d)
Prior to this change, jinja2 did not allow that. It mandated that all
splatting had to take place at the end of the call:
call_function('123', c=5, *b, **d)
This commit allows both orders.
Additionally, this commit adds tests for more things that are illegal:
namely giving a function a positional argument after using a splat to
unpack positional arguments or giving a function a named argument after
using a double splat to unpack keyword arguments.
There is now Python 3 support...
fix unrelated docs issue
Lazy asyncsupport.patch_all()
Found via `codespell -q 3` using v1.12.0.dev0
Fix typo: apparenlty -> apparently.
This unescapes after concatenating, to fix a bug introduced in Jinja 2.10 where lines concatenated contain escaped versions of non-ascii characters.
The previous commit assumes that the filter will always be a Markup type, which is not correct.
This ensures that we only concatenate Markup instances to other Markup instances.
Fix escaped characters in indent filter
This is unmaintained anyways and we do not want to ship non BSD code. Fixes pallets#833
|
Looks fine, but needs a test. In what circumstances is |
|
This happened when the exception was on python callback in a custom extension. I'll try to build a simple test case. |
Tested during CI since 761da6f.
Add trove classifier for PyPy support
Trim trailing white space throughout the project
Pass python_requires argument to setuptools
[Docs] Fix ambiguity in include section
parser: Fix typo `self.lineno` -> `token.lineno`
easy_install is deprecated and its use is discouraged by PyPA: https://setuptools.readthedocs.io/en/latest/easy_install.html > Warning: Easy Install is deprecated. Do not use it. Instead use pip. Follow upstream advice and only recommended supported tools. Replace with pip.
Clarify in docs that last filter doesn't work with generators
Remove reference to deprecated easy_install; use pip instead
This example attempts to handle both Windows-style and Unix-style line endings, but does it wrong; as noted at https://stackoverflow.com/q/12521127/1709587, the regex here will match a single \r\n as if it were a double line-break, which results in all single Windows-style line-breaks getting converted into <p> breaks instead of <br> breaks as intended. This patch fixes that by applying Alan Moore's proposed fix from https://stackoverflow.com/a/12521544/1709587 of using a negative lookahead so that a \r cannot be counted as a line break if it is followed by a \n (while still allowing the \r\n combination to count as a line break).
Fix broken nl2br filter example
Add testing and document support for Python 3.7 & pypy3
kevin-brown
force-pushed
the
2.10-maintenance
branch
from
9dfdace
to
633a8c1
Compare
|
Duplicate of #674 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations the Template '_debug_info' can be empty. This causes the real exception to be masked by a new ValueError exeception:
This bug fix simply check if '_debug_info' is not empty before working on it.